iffyio commented on PR #1435: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1435#issuecomment-2441139126
@Nyrox sorry for the delay in getting to this I don't have any major comments regarding the impl and it seems to align with previous discussions so I'm suspecting this is close. One aspect I'm not super clear on is how accurate/comprehensive we'll look to be regarding this feature going forward (primarily as it pertains to testing affected code paths), i.e. whether as a best effort, or similar to the other parser functionality (which expectedly requires more effort from PR authors when adding/updating features in the codebase) in order to properly power use cases like @lustefaniak mentions in #1480, or somewhere in-between. In any case, I would wait for @alamb for when time allows to take a look and provide any thoughts/feedback on the overall approach! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
