jayzhan211 commented on code in PR #13133:
URL: https://github.com/apache/datafusion/pull/13133#discussion_r1818593980
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -266,6 +319,35 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
}
}
+ #[inline]
+ fn is_eq_and_gt(&self, a: usize, b: usize) -> (bool, bool) {
Review Comment:
cursor[a] is the value, so we compare value actually
> Can match on and/or return [Ordering
](https://doc.rust-lang.org/std/cmp/enum.Ordering.html)instead? This will save
one comparison :)
Not sure what do you mean 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
