Dandandan commented on code in PR #13133:
URL: https://github.com/apache/datafusion/pull/13133#discussion_r1818541752
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -97,6 +97,26 @@ pub(crate) struct SortPreservingMergeStream<C: CursorValues>
{
/// Cursors for each input partition. `None` means the input is exhausted
cursors: Vec<Option<Cursor<C>>>,
+ /// Configuration parameter to enable round-robin selection of tied
winners of loser tree.
+ enable_round_robin_tie_breaker: bool,
Review Comment:
Do we want to make this configurable? Maybe it makes sense to enable it by
default if it's generally faster this way, this will avoid a branch as well or
extra code generation.
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -97,6 +97,26 @@ pub(crate) struct SortPreservingMergeStream<C: CursorValues>
{
/// Cursors for each input partition. `None` means the input is exhausted
cursors: Vec<Option<Cursor<C>>>,
+ /// Configuration parameter to enable round-robin selection of tied
winners of loser tree.
+ enable_round_robin_tie_breaker: bool,
Review Comment:
Do we want to make this configurable? Maybe it makes sense to enable it by
default if it's generally faster this way, this will avoid a branch as well or
extra code generation / boilerplate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
