alamb commented on PR #13045: URL: https://github.com/apache/datafusion/pull/13045#issuecomment-2438904693
> if it's just supported but not guaranteed (this PR), i am fine with the change -- LGTM > if we want to embrace nextest as the way to run tests -- i am probably fine to, but let's make sure we understand benefits and drawbacks I don't think this is necessary / good to try and push. I think allowing developers the freedom to use whatever tools they deem best is better than trying to require one particular toolset > they run without process-per-test isolation, which kills productivity if tests actuall leverage isolation. > (@alamb do you or someone at influx have a solution to this?) TLDR is we make sure all our tests are isolated / don't use global state -- which takes quite a bit of finagling when it involves subprocesses / end to end type tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
