OussamaSaoudi commented on code in PR #12981:
URL: https://github.com/apache/datafusion/pull/12981#discussion_r1816128823
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -114,17 +114,20 @@ impl DataFilePaths for &String {
}
}
-impl<P> DataFilePaths for Vec<P>
-where
- P: AsRef<str>,
-{
+impl DataFilePaths for Vec<&str> {
Review Comment:
Hmm I think this may fail since `AsRef<str>` doesn't
imply`Into<ListingTableUrl>`. It has to go through a `ListingTableUrl::parse`,
which is fallible.
I'll give it some more thought and play with the types. Perhaps I'll try to
change how `SessionContext::read_parquet` handles `AsRef<str>` and
`ListingTableUrl`.
Setting back to draft for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
