alamb commented on issue #13065: URL: https://github.com/apache/datafusion/issues/13065#issuecomment-2432693106
> The question I'd want answered is: does disabling this check hide an actual problem or are we confident the problem exists within the check itself? I believe disabling the check hides actual problems -- a list of such problems is here https://github.com/apache/datafusion/issues/12733 However, those plans ran in DataFusion 41 (and sometimes metadata was dropped from the output schema) and now the plans refuse to run. So depending on your perspective this is either an improvement or regression: * It is a regression for a user running SQL queries perspective because a query that used to run great no longer does * It is an improvement for a developer as it now makes it easy to find queries that violate invariants So having a flag to change behaviors based on your point of view I think makes sense > That is, do we know for certain that disabling the check isn't allowing faulty output? In general I recommend against features to disable checks but I also recognize that unblocking downstream users may be more important. No, we do not know this for certain. I think my point of view is that running with the check disabled is no worse than DataFusion 41 so while not ideal, it isn't worse -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
