andygrove commented on code in PR #1000:
URL: https://github.com/apache/datafusion-comet/pull/1000#discussion_r1810908082
##########
common/src/main/java/org/apache/comet/NativeBase.java:
##########
@@ -46,15 +46,24 @@ public abstract class NativeBase {
private static final String libraryToLoad =
System.mapLibraryName(NATIVE_LIB_NAME);
private static boolean loaded = false;
+ private static Throwable loadErr = null;
private static final String searchPattern = "libcomet-";
static {
- if (!isLoaded()) {
Review Comment:
`load` is a no-op if `loaded == false` so no need for this conditional here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
