findepi commented on PR #12953: URL: https://github.com/apache/datafusion/pull/12953#issuecomment-2429132928
The cost/benefit trade off depends on the perspective. At SDF, we have our own SQL frontend(s), so sqlparser-rs dependency is redundant. Being able to remove it would not only reduce binary size (probably not a lot), but more importantly, it would provide guarantees that some unwanted DF's SQL frontend related behavior isn't inherited (relates to https://github.com/apache/datafusion/issues/12723) > A feature cfg is probably best I suppose i will give it a try, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
