alamb commented on PR #12953: URL: https://github.com/apache/datafusion/pull/12953#issuecomment-2424907669
> @alamb what would you suggest? > this can be put behind a feature cfg, or maybe we add some dyn trait to DataFusionError to allow for dynamic binding A feature cfg is probably best I suppose > identifiers: We could make a trait in datafusion-sql maybe Though now that I see this list, I think maybe the extra code overhead of breaking this out won't really add much so perhaps it is not worth doing anything more at this time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
