Rachelint commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1807294769
##########
datafusion/physical-plan/src/aggregates/group_values/group_column.rs:
##########
@@ -128,6 +132,15 @@ impl<T: ArrowPrimitiveType, const NULLABLE: bool>
GroupColumn
}
}
+ fn append_non_nullable_val(&mut self, array: &ArrayRef, row: usize) {
+ if NULLABLE {
+ self.nulls.append(false);
Review Comment:
To eliminate this extra branch, I think we need to refactor the `intern`
process metioned in
https://github.com/apache/datafusion/issues/12821#issuecomment-2401542201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
