alamb commented on code in PR #12945:
URL: https://github.com/apache/datafusion/pull/12945#discussion_r1806995064
##########
datafusion/sqllogictest/test_files/subquery.slt:
##########
@@ -1028,6 +1028,80 @@ false
true
true
+# in_subquery_to_join_with_correlated_outer_filter_disjunction
Review Comment:
Could you also add `EXPLAIN` tests for these queries too so we can review if
the plans will generate the correct results?
##########
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##########
@@ -442,60 +520,6 @@ mod tests {
assert_optimized_plan_equal(plan, expected)
}
- /// Test for IN subquery with additional OR filter
Review Comment:
Why are these tests removed?
##########
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##########
@@ -1407,13 +1361,13 @@ mod tests {
.build()?;
let expected = "Projection: customer.c_custkey [c_custkey:Int64]\
- \n LeftSemi Join: Filter:
__correlated_sq_1.o_custkey = customer.c_custkey [c_custkey:Int64, c_name:Utf8]\
Review Comment:
The changes are that the auto generated subquery alias (e.g.
`__correlated_sq_1`) is a different order, right? Or are you referring to
something more substantial?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
