buraksenn commented on PR #12972: URL: https://github.com/apache/datafusion/pull/12972#issuecomment-2422436908
> > let mut x = &args[0]; Thus using args[0] did not cause any errors but of course not a best practice afais. > > x is re-set to args[1] if `log` has two parameters, so using args[0] should have caused inconsistent behavior (sometimes pointing to the base of log, sometimes to the actual log value) in that commit. This might have uncovered a bug. I am planning to investigate it further. I saw that now. Then probably test case miss this. I can add further tests on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
