buraksenn opened a new pull request, #12972: URL: https://github.com/apache/datafusion/pull/12972
## Which issue does this PR close? Partly Closes #12923 . ## Rationale for this change Copy-pasta'ing the issue description here: In https://github.com/apache/datafusion/pull/12881, https://github.com/apache/datafusion/pull/12890 it turned out that make_function_scalar_inputs_return_type may lead to less performant code. In https://github.com/apache/datafusion/pull/12909 it turned out that make_function_inputs2 may lead to less performant code. That's why this PR removes the last usage of `make_function_scalar_inputs` to use `unary` ## What changes are included in this PR? - Remove last usages of make_function_scalar_inputs - After #12909 is merged, I will rebase and delete `make_function_scalar_inputs` ## Are these changes tested? Existing testcases I can add benchmarks if requested or add when the others are refactored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
