alamb commented on code in PR #12897: URL: https://github.com/apache/datafusion/pull/12897#discussion_r1803191644
########## datafusion/functions/src/regex/regexplike.rs: ########## @@ -82,14 +83,27 @@ Additional examples can be found [here](https://github.com/apache/datafusion/blo impl RegexpLikeFunc { pub fn new() -> Self { - use DataType::*; Self { signature: Signature::one_of( vec![ + TypeSignature::Exact(vec![Utf8View, Utf8]), + TypeSignature::Exact(vec![Utf8View, Utf8View]), + TypeSignature::Exact(vec![Utf8View, LargeUtf8]), TypeSignature::Exact(vec![Utf8, Utf8]), + TypeSignature::Exact(vec![Utf8, Utf8View]), + TypeSignature::Exact(vec![Utf8, LargeUtf8]), + TypeSignature::Exact(vec![LargeUtf8, Utf8]), + TypeSignature::Exact(vec![LargeUtf8, Utf8View]), TypeSignature::Exact(vec![LargeUtf8, LargeUtf8]), + TypeSignature::Exact(vec![Utf8View, Utf8, Utf8]), Review Comment: I think requiring the flags array to be StringArrray (aka only supporting `Utf8` as the third argument) makes lots of sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
