goldmedal commented on issue #12924: URL: https://github.com/apache/datafusion/issues/12924#issuecomment-2412675078
> @goldmedal Do you think we should add tests for something like this in your `sqllogictech` string files? It feels like operators on everything × everything should catch it. For example, I could find this issue by doing: Sure, I think it's good to have a test framework to test a string type with other string types. We only do this kind of thing at https://github.com/apache/datafusion/blob/fce331a4f7ca908ee7b4500d104fae9ec657f471/datafusion/sqllogictest/test_files/string/string_view.slt#L106-L110 If you want to add the test for `StirngView` specifically, I guess you can do it in this part. Or if you want to do it for all string types, you could create the testing data in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/string/init_data.slt.part and add the tests in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/string/string_query.slt.part -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
