findepi commented on code in PR #12880:
URL: https://github.com/apache/datafusion/pull/12880#discussion_r1797750741
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -293,7 +293,7 @@ fn get_approx_percentile_cont_doc() -> &'static
Documentation {
| 65.0 |
+-------------------------------------------------+
```"#)
- .with_argument("expression", "Expression to operate on. Can be a
constant, column, or function, and any combination of arithmetic operators.")
+ .with_standard_argument("expression", "The")
Review Comment:
Thanks for the link. `"The"` still looks weird to me. I guess it gets
concatenated with something else.
if i follow the link correctly, this gets passed as `expression_type`
argument, but "The" does not look like expression type.
Could we have an overload so that `"The"` is not needed?
eg `with_standard_sole_argument` could produce "The expression to operate
on. Can be a constant, column, or function, and any combination of operators."
without requiring "The" from the caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
