andygrove commented on code in PR #1007:
URL: https://github.com/apache/datafusion-comet/pull/1007#discussion_r1794237336
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -263,6 +263,12 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
+ val COMET_REPLACE_SMJ: ConfigEntry[Boolean] =
+ conf(s"$COMET_EXEC_CONFIG_PREFIX.replaceSortMergeJoin")
+ .doc("Whether to replace SortMergeJoin with ShuffledHashJoin for
improved performance.")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
The other accelerators (Spark RAPIDS and Gluten) default this to true.
Perhaps we should benchmark at large scale factors before and see if we run
into any issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
