viirya commented on code in PR #1007:
URL: https://github.com/apache/datafusion-comet/pull/1007#discussion_r1794234836
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -263,6 +263,12 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
+ val COMET_REPLACE_SMJ: ConfigEntry[Boolean] =
+ conf(s"$COMET_EXEC_CONFIG_PREFIX.replaceSortMergeJoin")
+ .doc("Whether to replace SortMergeJoin with ShuffledHashJoin for
improved performance.")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
I think we should have a default value as false for stablility. Spark
decides to use SMJ for some reasons including data statistics. If Spark thinks
SHJ may not work, I think we better follow it except for explicitly asking by
users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
