jonahgao commented on code in PR #12808:
URL: https://github.com/apache/datafusion/pull/12808#discussion_r1792685135
##########
datafusion/physical-plan/Cargo.toml:
##########
@@ -69,6 +68,7 @@ rand = { workspace = true }
tokio = { workspace = true }
[dev-dependencies]
+datafusion-functions-aggregate = { workspace = true }
Review Comment:
I found that some tests call private methods, which means we can't move them
to a different package. Perhaps we can address this in a subsequent PR.
##########
datafusion/physical-plan/Cargo.toml:
##########
@@ -69,6 +68,7 @@ rand = { workspace = true }
tokio = { workspace = true }
[dev-dependencies]
+datafusion-functions-aggregate = { workspace = true }
Review Comment:
I found that some tests call private methods, which means we can't move them
to a different package. Perhaps we can try to address this in a subsequent PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
