jonahgao commented on code in PR #12808:
URL: https://github.com/apache/datafusion/pull/12808#discussion_r1792068585
##########
datafusion/physical-plan/Cargo.toml:
##########
@@ -69,6 +68,7 @@ rand = { workspace = true }
tokio = { workspace = true }
[dev-dependencies]
+datafusion-functions-aggregate = { workspace = true }
Review Comment:
Some tests
[require](https://github.com/apache/datafusion/blob/7d360599586b413b0f433fdc062a5b282dd10c6f/datafusion/physical-plan/src/aggregates/mod.rs#L1456)
an aggregate function and will check the aggregation results, so not sure if
it's possible to remove this dependency 🤔.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
