andygrove commented on PR #1002: URL: https://github.com/apache/datafusion-comet/pull/1002#issuecomment-2400258972
> I'm a bit worried about this approach because we are implementing greedy mode inside `CometTaskMemoryManager`, which is known to starve consumers frequently. I prefer using fair spill pool for "native memory management" mode. This makes spillable operators work properly without being starved but with the cost of memory pool under-utilization. Thanks for the feedback. I will work on a separate PR for the fair spill approach. I am moving this PR to draft for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
