alamb commented on code in PR #12646:
URL: https://github.com/apache/datafusion/pull/12646#discussion_r1779658251
##########
datafusion/physical-expr/src/expressions/binary/kernels.rs:
##########
@@ -24,7 +24,7 @@ use arrow::compute::kernels::bitwise::{
bitwise_xor, bitwise_xor_scalar,
};
use arrow::datatypes::DataType;
-use datafusion_common::internal_err;
+use datafusion_common::plan_err;
Review Comment:
I was thinking that most `plan_err` s are issues with a user's query (some
bug they should fix) where as `not_impl` signals that there isn't some bug with
the query
This is kind of documented here:
*
https://docs.rs/datafusion/latest/datafusion/common/enum.DataFusionError.html#variant.Plan
*
https://docs.rs/datafusion/latest/datafusion/common/enum.DataFusionError.html#variant.NotImplemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
