dharanad commented on code in PR #12646:
URL: https://github.com/apache/datafusion/pull/12646#discussion_r1779463677
##########
datafusion/physical-expr/src/expressions/binary/kernels.rs:
##########
@@ -24,7 +24,7 @@ use arrow::compute::kernels::bitwise::{
bitwise_xor, bitwise_xor_scalar,
};
use arrow::datatypes::DataType;
-use datafusion_common::internal_err;
+use datafusion_common::plan_err;
Review Comment:
it seems unlikely that we would support such an operation so `plan_err`
should be good right ? However, I may be overlooking some factors. Could you
please clarify if there's a specific rationale behind this suggestion that I
might have missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
