jayzhan211 commented on PR #12269: URL: https://github.com/apache/datafusion/pull/12269#issuecomment-2369774073
@alamb @eejbyfeldt Thanks for your review, could take another quick look then merge this PR. TODOs of follow on - [ ] Implement a ByteGroupValueBuilder for StringView and the other primitive based types (e.g. DecimalArray, the date/time stuff, etc) - [ ] Simplify / Improve single group value case `GroupValuesPrimitive` and `GroupValuesByes`, maybe with `ArrowRowEq` - [ ] Vectorize the row equality check + append row -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
