alamb commented on issue #12394: URL: https://github.com/apache/datafusion/issues/12394#issuecomment-2366764605
> If we want to use dyn Session, we must move the API SessionState::get_file_format_factory to dyn Session. It may involve FileFormat and FileFormatFactory, which this API requires. This seems reasonable to me > However, the file_formats and configs will be static. We can't register additional formats or change configs at the runtime. (if we want to change them at the runtime, we need to make them be something like share reference 🤔 ) Then, we can remove SessionStore to avoid the issue of registering the current state after building SessionState. I agree this sounds not good. 🤔 I vaguely remember that something similar is needed for `information_schema` (where it also has to be created after the other providers or something)... Anyhow, thank you for this thorough review. I d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
