devanbenz commented on issue #6906:
URL: https://github.com/apache/datafusion/issues/6906#issuecomment-2365379616

   > > > while working on #12092 it turns out that Min / Max on BinaryView and 
StringView are suuuuper slow.
   > > 
   > > 
   > > Fixed in #12575, now min/max on `StringViewArray` should be slightly 
faster than `StringArray`
   > 
   > I mean, fixed for that particular clickbench query which does not leverage 
stats to prune parquet access.
   
   Cool, I'm assuming this change didn't impact the `GroupsAccumulatorAdapter` 
call in anyway since I'm still seeing a similar performance + flamegraph with 
the following query:
   
   ```
   set datafusion.execution.parquet.schema_force_view_types = true;
   
   
   SELECT REGEXP_REPLACE("Referer", '^https?://(?:www\\.)?([^/]+)/.*$', '\\1') 
AS k, AVG(length("Referer")) AS l, COUNT(*) AS c, MIN("Referer")
   FROM hits_partitioned
   WHERE "Referer" <> '' GROUP BY k HAVING COUNT(*) > 100000 ORDER BY l DESC 
LIMIT 25;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to