alexanderbianchi commented on code in PR #113:
URL: 
https://github.com/apache/datafusion-iceberg/pull/113#discussion_r4623421705


##########
crates/datafusion/src/read/file_scan_task_provider/lazy.rs:
##########
@@ -250,6 +257,43 @@ impl FileScanTaskProvider for LazyFileScanTaskProvider {
         ))
     }
 
+    /// Estimates the rows the scan returns before its predicate and fetch,
+    /// from the snapshot summary.
+    ///
+    /// `total-records` counts rows before deletes, so the estimate is an upper
+    /// bound. Deletes aren't subtracted, because the spec lets
+    /// `total-position-deletes` count more rows than the deletes remove. A
+    /// position delete file can stay live after the data files it references
+    /// are removed. A deletion vector repeats the deletes of position delete
+    /// files that can stay live beside it. An underestimate can make join
+    /// selection collect a large table as the build side. Summary fields are
+    /// optional, so a missing or invalid `total-records` leaves the estimate
+    /// unknown rather than failing the query.
+    fn estimated_num_rows(&self) -> Precision<usize> {

Review Comment:
   Just being moved not new to this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to