alexanderbianchi commented on code in PR #113:
URL: 
https://github.com/apache/datafusion-iceberg/pull/113#discussion_r4623418714


##########
crates/datafusion/src/read/file_scan_task_provider/eager.rs:
##########
@@ -30,6 +31,9 @@ use super::provider::{FileScanTaskProvider, 
FileScanTaskProviderContext};
 #[derive(Debug)]
 pub struct EagerFileScanTaskProvider {
     file_scan_tasks: Vec<Vec<FileScanTask>>,
+    /// Snapshot estimate retained when converting lazy discovery; external

Review Comment:
   We will improve this in a follow up PR so that we estimate based on the 
remaining manifests, it needs a bump to the iceberg_rust dep for 
https://github.com/apache/iceberg-rust/pull/3424



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to