marvelefe commented on PR #27470: URL: https://github.com/apache/datafusion/pull/27470#issuecomment-6994534730
> @marvelefe thanks for the updates, all four earlier points are addressed. One more tree-format issue is inline. > > Optional, for the description: it says the `OrderingEquivalenceClass` `Display` change only shows up in tests and debug messages, but `SanityCheckPlan` prints it in its "does not satisfy order requirements ... Child-0 order: ..." error (`sanity_checker.rs` line 197), so users who hit that error will also see `NULLS FIRST` spelled out. Could you mention that too? @jayzhan211 I've added the `SanityCheckPlan` error case to the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
