andygrove commented on code in PR #340:
URL: https://github.com/apache/datafusion-spark/pull/340#discussion_r4621326026


##########
crates/sqllogictest/test_files/url/parse_url.slt:
##########
@@ -337,10 +337,17 @@ SELECT parse_url('inva 
lid://spark.apache.org/path?query=1', 'QUERY');
 NULL
 
 query T
-SELECT parse_url('http://spark.apache.org:99999/path', 'HOST');
+SELECT parse_url('http://[::1/path', 'HOST');
 ----
 NULL
 
+# Known difference from Spark: java.net.URI doesn't range-check the port, so

Review Comment:
   I opened #365 to track the port handling. Could you reference it in this 
comment, for example `# Known difference from Spark, tracked in #365`? That way 
whoever fixes it knows to uncomment this record.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to