andygrove opened a new pull request, #360: URL: https://github.com/apache/datafusion-spark/pull/360
## Which issue does this PR close? - Relates to #88 and #346. ## Rationale for this change #89, #304, #345 and #350 added a shared way to declare a function's input types, find a common type, cast a value and read ANSI mode. `CONTRIBUTING.md` does not mention any of them, so a new function is likely to hand-write a `Signature`, call Arrow's `cast`, or take a `bool` for ANSI mode instead. ## What changes are included in this PR? - A new "Input types, casts and ANSI mode" section in `CONTRIBUTING.md`. It says when to use `SparkInputTypes`, the rules in `type_coercion.rs`, `spark_cast()` and `EvalMode`, and that ANSI on and off should both be tested in SLT. - The audit skill's "Signature and coercion" and "ANSI handling" checks now point at the same pieces. The section says that `SparkInputTypes` only chooses target types and that `spark_cast()` returns "not implemented" for casts that are not ported yet (#88). I kept that wording on purpose, so it can be relaxed as the cast port progresses. ## Are these changes tested? Documentation only. I checked each name, path and example against `apache/main` (`sha2.rs`, `parse_url.rs`, `array_position.rs`, `implicit_cast.rs`, `type_coercion.rs`, `eval_mode.rs`, `cast/mod.rs`). ## Are there any user-facing changes? No. This PR was written with the help of an LLM (Claude Code). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
