NoahKusaba opened a new pull request, #119: URL: https://github.com/apache/datafusion-iceberg/pull/119
## Which issue does this PR close? N/A. Refactor. ## Rationale for this change `IcebergMetadataTableProvider` has a public inherent `async fn scan(self)` with the same name as `TableProvider::scan` but a different meaning: it consumes the provider and returns a stream of batches. Its only caller is `IcebergMetadataDataSource::open`, so reading rows is the data source's job, not part of the provider's public API. ## What changes are included in this PR? - Removes `IcebergMetadataTableProvider::scan(self)`. - Moves its body, unchanged, to a private `read_all` in `metadata/scan.rs`, next to its caller. ## Are there any user-facing changes? Yes, breaking: the public `IcebergMetadataTableProvider::scan(self)` is removed. Metadata tables are still queried through SQL (`t$snapshots`, ...) or `TableProvider::scan`, as before. ## Are these changes tested? Yes. `$snapshots` and `$manifests` were already read in tests; this adds `reads_the_history_table`, since `$history` was only listed, never read. It passes on `main` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
