rkrishn7 commented on code in PR #27499:
URL: https://github.com/apache/datafusion/pull/27499#discussion_r4596048052
##########
datafusion/physical-plan/src/aggregates/group_values/mod.rs:
##########
@@ -84,6 +84,14 @@ pub trait GroupValues: Send {
/// assigned.
fn intern(&mut self, cols: &[ArrayRef], groups: &mut Vec<usize>) ->
Result<()>;
+ /// Looks up the group id for each input row of `cols` without assigning
+ /// new group ids.
+ ///
+ /// When the function returns, `groups` has been cleared and contains one
+ /// entry per input row: `Some(group_id)` if the value is already stored
+ /// and `None` otherwise. Stored values and group ids are unchanged.
+ fn find(&mut self, cols: &[ArrayRef], groups: &mut Vec<Option<usize>>) ->
Result<()>;
Review Comment:
Agreed - updated in
[905cecd](https://github.com/apache/datafusion/pull/27499/commits/905cecd9f54b3a0b422f9e91c2e8c96728b1b2bc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]