rkrishn7 commented on code in PR #27499:
URL: https://github.com/apache/datafusion/pull/27499#discussion_r4596044440


##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -1213,6 +1310,8 @@ impl<const STREAMING: bool> GroupValues for 
GroupValuesColumn<STREAMING> {
                 // a real Result rather than panicking.
                 let fresh = Self::build_group_columns(&self.schema)?;
                 let group_values = mem::replace(&mut self.group_values, fresh);
+                self.map.clear();
+                self.group_index_lists.clear();

Review Comment:
   Yes good call, I think it's best to split out into another PR. I filed 
https://github.com/apache/datafusion/pull/27501. That does need to be merged 
first as a call to `find()` after `emit()` relies on the hashmap being cleared.



##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -331,7 +331,7 @@ where
 
                 self.map
                     .find(hash, |header| {
-                        if header.hash != hash {
+                        if header.hash != hash || header.view as u32 != len {

Review Comment:
   Split out as mentioned below



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to