andygrove commented on code in PR #7352:
URL: https://github.com/apache/datafusion-comet/pull/7352#discussion_r4592055112


##########
docs/source/contributor-guide/ci.md:
##########
@@ -169,6 +168,42 @@ If you cannot enable Actions on your fork, say so on the 
pull request. Nothing e
 tier for you before the queue does, so a maintainer may ask you to reproduce a 
failure with
 [`dev/local-ci.sh`](#reproducing-a-suite-failure-locally) first.
 
+### When the fork check finds no run
+
+When no run of your fork exists for the pull request's head commit, `CI 
(fork)` says one of two
+things:
+
+- **Enable CI on your fork.** Your fork has no enabled `Comet CI (fork run)` 
workflow. Usually
+  GitHub Actions was never enabled on the fork, or no branch that includes the 
fork workflows has
+  been pushed to it. GitHub shows this check as failed because it asks you to 
act. It does not block
+  merging. The check says only that no run of your fork was found for this 
commit. A pull request
+  opened before the PR tier moved to forks can still have results of the PR 
tier from here, as
+  [below](#when-the-fork-check-finds-no-run) says, and otherwise a reviewer 
has no CI result to go
+  on.
+- **No fork CI run for this commit.** The workflow exists but has no run for 
this commit. Either
+  the run has not appeared yet, or the commit was pushed before Actions was 
enabled.
+
+Either way, the fix is the three steps above, followed by a new push:

Review Comment:
   Restored. The second bullet now lists the run not having appeared yet, the 
branch not including the fork workflows, and the commit having been pushed 
before Actions was enabled. The sentence after it now starts "If your fork's 
Actions tab has no run for this commit" (f8aa438dc7).



##########
docs/source/contributor-guide/ci.md:
##########
@@ -169,6 +168,42 @@ If you cannot enable Actions on your fork, say so on the 
pull request. Nothing e
 tier for you before the queue does, so a maintainer may ask you to reproduce a 
failure with
 [`dev/local-ci.sh`](#reproducing-a-suite-failure-locally) first.
 
+### When the fork check finds no run
+
+When no run of your fork exists for the pull request's head commit, `CI 
(fork)` says one of two
+things:
+
+- **Enable CI on your fork.** Your fork has no enabled `Comet CI (fork run)` 
workflow. Usually
+  GitHub Actions was never enabled on the fork, or no branch that includes the 
fork workflows has
+  been pushed to it. GitHub shows this check as failed because it asks you to 
act. It does not block
+  merging. The check says only that no run of your fork was found for this 
commit. A pull request
+  opened before the PR tier moved to forks can still have results of the PR 
tier from here, as
+  [below](#when-the-fork-check-finds-no-run) says, and otherwise a reviewer 
has no CI result to go
+  on.
+- **No fork CI run for this commit.** The workflow exists but has no run for 
this commit. Either
+  the run has not appeared yet, or the commit was pushed before Actions was 
enabled.
+
+Either way, the fix is the three steps above, followed by a new push:
+
+```shell
+# 1. Enable Actions in your fork's Actions tab, then:
+git fetch upstream
+git push origin upstream/main:main   # 2. sync your fork's main (or use "Sync 
fork" on GitHub)
+git merge upstream/main              # 3. bring the fork workflows into your 
branch (or rebase)
+git push                             # starts a Comet CI (fork run) in your 
fork

Review Comment:
   Good catch. The comment on the push line now says to use 
`--force-with-lease` after a rebase (f8aa438dc7).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to