blaginin commented on code in PR #27439:
URL: https://github.com/apache/datafusion/pull/27439#discussion_r4591196826
##########
datafusion/expr/src/udaf.rs:
##########
@@ -1736,6 +1736,11 @@ impl AggregateUDFImpl for AliasedAggregateUDFImpl {
/// values always increase (or stay the same) as new values are seen. On
/// the other hand, `MIN` is monotonically decreasing as its value always
/// decreases or stays the same as new values are seen.
+///
+/// A set-monotonic aggregate may return NULL for an empty input or an input
+/// containing only NULLs. Once a non-NULL input is present, its result must be
+/// non-NULL. Adding inputs must never change a non-NULL result back to NULL,
+/// so growing window frames can only have a prefix of NULL results.
Review Comment:
I feel that we already have this assumption in the code - it's just not
called out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]