waruto210 commented on code in PR #12471:
URL: https://github.com/apache/datafusion/pull/12471#discussion_r1764576949
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -817,6 +817,20 @@ impl TableProvider for ListingTable {
.map(|col| Ok(self.table_schema.field_with_name(&col.0)?.clone()))
.collect::<Result<Vec<_>>>()?;
+ // If the filters can be resolved using only partition cols, there is
no need to
+ // pushdown it to TableScan, otherwise, `unhandled` pruning predicates
will be generated
+ let table_partition_col_names = table_partition_cols
Review Comment:
`filters` are passed as parameters to `ListingTable::scan`, so I believe
storing `table_partition_col_names` or `filters` in ListingTable has no
practical use. Additionally, I think the correctness of this change can be
covered by existing tests, such as those in
`datafusion/core/tests/sql/path_partition.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
