viirya commented on code in PR #7400:
URL: https://github.com/apache/datafusion/pull/7400#discussion_r1764000962
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -1506,24 +1526,53 @@ mod tests {
let result =
common::collect(partial_aggregate.execute(0,
task_ctx.clone())?).await?;
- let expected = vec![
- "+---+-----+-----------------+",
- "| a | b | COUNT(1)[count] |",
- "+---+-----+-----------------+",
- "| | 1.0 | 2 |",
- "| | 2.0 | 2 |",
- "| | 3.0 | 2 |",
- "| | 4.0 | 2 |",
- "| 2 | | 2 |",
- "| 2 | 1.0 | 2 |",
- "| 3 | | 3 |",
- "| 3 | 2.0 | 2 |",
- "| 3 | 3.0 | 1 |",
- "| 4 | | 3 |",
- "| 4 | 3.0 | 1 |",
- "| 4 | 4.0 | 2 |",
- "+---+-----+-----------------+",
- ];
+ let expected = if spill {
+ vec![
+ "+---+-----+-----------------+",
Review Comment:
That's right. When spilling happens, it means we don't have enough memory to
hold original batch so we will do partial aggregation on smaller batch,
different partial aggregation result will be but I think it doesn't change
final aggregation result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
