andygrove commented on code in PR #2862:
URL: 
https://github.com/apache/datafusion-ballista/pull/2862#discussion_r4579294009


##########
ballista/client/src/prelude.rs:
##########
@@ -18,3 +18,4 @@
 //! Ballista Prelude (common imports)
 
 pub use crate::extension::{SessionConfigExt, SessionContextExt};
+pub use ballista_core::config::ExecutionMode;

Review Comment:
   Since `ExecutionMode` is new in 56.0.0 and this PR puts it in the prelude, 
would it be worth marking it `#[non_exhaustive]` before the release? It costs 
nothing right now because nothing outside `ballista-core` matches on it yet. 
Once 56.0.0 ships, adding it later would be a breaking change. Happy for this 
to be a quick follow-up if you'd rather keep the PR focused.



##########
ballista/core/src/extension.rs:
##########
@@ -306,6 +306,13 @@ pub trait SessionConfigExt {
     fn ballista_skew_join_small_partition_factor(&self) -> f64;
     /// Sets the tail-merge factor for the skew-join sub-shard bin-packer.
     fn with_ballista_skew_join_small_partition_factor(self, factor: f64) -> 
Self;
+
+    /// Returns how a job's stages exchange data, as an [`ExecutionMode`].
+    ///
+    /// Returns an error if `ballista.execution.mode` is not a valid value.
+    fn ballista_execution_mode(&self) -> 
datafusion::error::Result<ExecutionMode>;
+    /// Sets how a job's stages exchange data. By default, this is set to 
`Staged`.

Review Comment:
   Small doc suggestion. Could we link the variant, as in 
[`ExecutionMode::Staged`], and mention that `Pipelined` needs a push-staged 
scheduler? That saves someone a trip to the user guide when a pull-staged 
cluster rejects the job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to