dwsmith1983 commented on code in PR #7556:
URL: https://github.com/apache/datafusion-comet/pull/7556#discussion_r4559257284


##########
native/core/src/parquet/objectstore/s3.rs:
##########
@@ -69,11 +70,12 @@ pub fn create_store(
     configs: &HashMap<String, String>,
     min_ttl: Duration,
 ) -> Result<(Box<dyn ObjectStore>, Path), object_store::Error> {
-    let (scheme, path) = ObjectStoreScheme::parse(url)?;
+    // The parser quotes the URL it rejects.
+    let (scheme, path) = ObjectStoreScheme::parse(&without_credentials(url))?;

Review Comment:
   Done in b749d6880. `create_store` strips the URL once at the top and 
`S3StoreTemplate::new` stores `url.to_string()` again. The template test went 
away with the second strip, so 
`create_store_errors_do_not_echo_userinfo_or_query` now also takes an 
`https://...amazonaws.com` URL that the parser accepts and the S3 builder 
rejects; the builder's error quotes the URL the template holds.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to