comphead commented on code in PR #7446:
URL: https://github.com/apache/datafusion-comet/pull/7446#discussion_r4554846572


##########
docs/source/download.md:
##########
@@ -0,0 +1,62 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+
+# Download
+
+Apache DataFusion Comet is released as source code. The current release is 
**1.2.0**.
+
+## Source release
+
+- 
[apache-datafusion-comet-1.2.0.tar.gz](https://www.apache.org/dyn/closer.lua/datafusion/datafusion-comet-1.2.0/apache-datafusion-comet-1.2.0.tar.gz?action=download)
 (source tarball)
+- 
[apache-datafusion-comet-1.2.0.tar.gz.asc](https://downloads.apache.org/datafusion/datafusion-comet-1.2.0/apache-datafusion-comet-1.2.0.tar.gz.asc)
 (PGP signature)
+- 
[apache-datafusion-comet-1.2.0.tar.gz.sha512](https://downloads.apache.org/datafusion/datafusion-comet-1.2.0/apache-datafusion-comet-1.2.0.tar.gz.sha512)
 (SHA-512 checksum)
+
+The tarball is served from the nearest Apache mirror. The signature and 
checksum are served by the Apache Software
+Foundation and must not be taken from a mirror. The public keys of the release 
managers are in the
+[KEYS](https://downloads.apache.org/datafusion/KEYS) file.
+
+The release notes are in the [changelog](changelog/1.2.0.md).
+See [Building Comet From Source](user-guide/latest/source.md) for how to build 
the tarball.

Review Comment:
   On the site `user-guide/latest/` is the development snapshot. 
`generate_docs` strips the `<!-- IF_RELEASE -->` blocks there and keeps the 
`<!-- IF_SNAPSHOT -->` ones, so this link opens a section that says "Published 
source releases are only available for released versions", and the installation 
guide link on line 56 opens the nightly snapshot jars section. The release text 
with the tarball commands is only in the versioned copy that 
`publish_released_version` builds from `branch-1.2`. Could both links point at 
`user-guide/1.2/` instead, with the release step that updates them kept? Sphinx 
builds from `docs/temp`, where that directory exists, but I have not built the 
docs to confirm that the path resolves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to