vinycalves commented on code in PR #27346: URL: https://github.com/apache/datafusion/pull/27346#discussion_r4551341658
########## datafusion/physical-plan/src/joins/sort_merge_join/tests.rs: ########## Review Comment: Does the new test cover a computed join key and the spill/read-back path, where the key array is actually unshared? When a batch spills, does the reservation still avoid double-counting buffers shared with the key arrays? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
