Kristofferjoha commented on code in PR #27346: URL: https://github.com/apache/datafusion/pull/27346#discussion_r4552201430
########## datafusion/physical-plan/src/joins/sort_merge_join/tests.rs: ########## Review Comment: Thanks, added a test which covers a computed key and the spill/read-back path. On spill the batch is dropped, so only the key arrays stay in memory and they’re counted once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
