comphead commented on PR #7584: URL: https://github.com/apache/datafusion-comet/pull/7584#issuecomment-6803671381
@andygrove thanks, good catch. I checked that the old test passed with `get_runtime().block_on(tokio::time::timeout_at(..))` in place of the parked wait. Keeping only the test runtime's single worker busy didn't catch it either, because a timer on the global runtime fires on its idle workers. In 7a4adf633d the test runs the producer on `get_runtime()`, keeps all of its workers busy until two publishes, and checks the count each busy task saw. With a Tokio timer it fails with 1 publish, and with the pre-PR `blocking_recv` it fails with 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
