rgbuilds commented on PR #26996: URL: https://github.com/apache/datafusion/pull/26996#issuecomment-6788689571
@gabotechs I just ran the SF1 reproducer with `tpchgen-cli 1.1.1`. As expected, the original `l_quantity < p_size` query still falls back because physical planning introduces an `Int32` → `Decimal128` cast: - Estimate: `6,001,215` - Actual: `2,932,286` - Q-error: `2.05x` I also tested the cast-free path added by this PR using `l_linenumber < p_size` (`Int32 < Int32`) on the same data: - Before this PR: `6,001,215` estimated vs. `5,637,859` actual (`1.064x`) - With this PR: `5,521,118` estimated vs. `5,637,859` actual (`1.021x`) So the supported column-to-column path improves the estimate. The original query still requires cast-expression support, as discussed in the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
