gabotechs commented on code in PR #27188:
URL: https://github.com/apache/datafusion/pull/27188#discussion_r4522261419
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1463,6 +1463,98 @@ async fn roundtrip_union2() -> Result<()> {
.await
}
+#[tokio::test]
+async fn roundtrip_union_join_duplicate_column_names() -> Result<()> {
Review Comment:
These tests seem a bit inconsistent in shape with the other ones in this
file.
Are they really providing extra coverage vs the other unit and .slt tests in
this PR? if not, I'd just remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
