MrBisonte commented on code in PR #2841:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2841#discussion_r4517717512
##########
tests/sqlparser_common.rs:
##########
@@ -23481,3 +23481,62 @@ fn
parse_trailing_end_keyword_is_not_silently_dropped() {
ParserError::ParserError("Expected: end of statement, found:
END".to_string())
);
}
+
+#[test]
+fn parse_create_procedure_string_body() {
+ match verified_stmt("CREATE PROCEDURE p (a INT) LANGUAGE sql AS 'INSERT
INTO t VALUES (a)'") {
+ Statement::CreateProcedure {
+ language,
+ body: CreateProcedureBody::AsString { body, link_symbol },
+ ..
+ } => {
+ assert_eq!(language, Some(Ident::new("sql")));
+ assert_eq!(
+ body,
+ Expr::Value(
+ Value::SingleQuotedString("INSERT INTO t VALUES
(a)".to_string())
+ .with_empty_span()
+ )
+ );
+ assert_eq!(link_symbol, None);
+ }
+ stmt => panic!("unexpected statement: {stmt:?}"),
+ }
+
+ verified_stmt("CREATE PROCEDURE p () LANGUAGE C AS 'MODULE_PATHNAME',
'p_wrapper'");
+ one_statement_parses_to(
+ "CREATE PROCEDURE p () AS 'SELECT 1' LANGUAGE sql",
+ "CREATE PROCEDURE p () LANGUAGE sql AS 'SELECT 1'",
+ );
+
+ pg_and_generic().verified_stmt(
+ "CREATE PROCEDURE p (a INT) LANGUAGE plpgsql AS $$ BEGIN INSERT INTO t
VALUES (a); END; $$",
+ );
+ pg_and_generic().verified_stmt("CREATE PROCEDURE p () LANGUAGE sql AS
$body$ SELECT 1 $body$");
Review Comment:
Thanks for the feedback, also addressed in 7d35f4db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
