alamb commented on code in PR #26437:
URL: https://github.com/apache/datafusion/pull/26437#discussion_r4473190815
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -1435,6 +1477,46 @@ impl SessionStateBuilder {
self
}
+ /// Set the [`sqlparser`] dialect object used to parse SQL.
+ ///
+ /// Use this method for a dialect that `datafusion.sql_parser.dialect`
+ /// cannot name, for example a custom implementation of
+ /// [`sqlparser::dialect::Dialect`].
+ ///
+ /// The dialect object takes precedence over the dialect name in the
+ /// session config. If it is set, [`SessionContext::sql`],
Review Comment:
do we really need to list all the (current) users of this setting?
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -1435,6 +1477,46 @@ impl SessionStateBuilder {
self
}
+ /// Set the [`sqlparser`] dialect object used to parse SQL.
+ ///
+ /// Use this method for a dialect that `datafusion.sql_parser.dialect`
Review Comment:
I think this could be shorter "Use this method for custom dialects that are
not supported by ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
