gabotechs commented on code in PR #26593:
URL: https://github.com/apache/datafusion/pull/26593#discussion_r4484920042


##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -217,6 +237,10 @@ pub struct RangePartitioning {
     samples: Arc<[SplitPoint]>,
     /// Effective boundaries for the current partition count.
     split_points: Arc<[SplitPoint]>,
+    /// Inclusive start of the key space, in `ordering` order.
+    start_bound: Option<SplitPoint>,
+    /// Exclusive end of the key space, in `ordering` order.
+    end_bound: Option<SplitPoint>,

Review Comment:
   Aren't you in the same situation with the current spec? For an empty 
dataset, the current spec implicitly says its bounds are -inf +inf, this would 
just set it explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to