abp002 commented on PR #26942: URL: https://github.com/apache/datafusion/pull/26942#issuecomment-6720334690
Thanks for the review, @jayzhan211! I rebased on main and gated on `output_needs_compensation` as you suggested, so the lookup is only done once. I also changed the HAVING arm to `IS NOT TRUE` and added your query as a test: it returned `1 1` before the change and `1 NULL` now. The only other change is the two EXPLAIN lines in `subquery.slt`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
